Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): improve display err on worker command #5277

Merged
merged 3 commits into from Jun 24, 2020
Merged

Conversation

yesnault
Copy link
Member

Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Copy link
Member

@richardlt richardlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove cast to sdk.Error and use writError func

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

29.5% 29.5% Coverage
9.0% 9.0% Duplication

@richardlt richardlt merged commit e0842e5 into master Jun 24, 2020
@richardlt richardlt deleted the ye-err-wk-cmd branch July 13, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants