Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api,ui): add workflow retention policy #5474

Merged
merged 17 commits into from Oct 8, 2020
Merged

feat(api,ui): add workflow retention policy #5474

merged 17 commits into from Oct 8, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Oct 5, 2020

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@sguiheux sguiheux marked this pull request as ready for review October 6, 2020 15:37
@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 6, 2020

CDS Report build-all-cds#14630.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh ovh deleted a comment from ovh-cds Oct 7, 2020
@ovh ovh deleted a comment from ovh-cds Oct 7, 2020
@ovh ovh deleted a comment from ovh-cds Oct 7, 2020
@ovh ovh deleted a comment from ovh-cds Oct 7, 2020
@ovh ovh deleted a comment from ovh-cds Oct 7, 2020
yesnault
yesnault requested changes Oct 7, 2020
View reviewed changes
cli/cdsctl/admin_workflow.go Outdated Show resolved Hide resolved
docs/content/docs/concepts/files/workflow-syntax.md Outdated Show resolved Hide resolved
docs/content/docs/concepts/workflow/retention.md Outdated Show resolved Hide resolved
docs/content/docs/concepts/workflow/retention.md Outdated Show resolved Hide resolved
docs/content/docs/concepts/workflow/retention.md Outdated Show resolved Hide resolved
docs/content/docs/concepts/workflow/retention.md Outdated Show resolved Hide resolved
docs/content/docs/concepts/workflow/retention.md Outdated Show resolved Hide resolved
docs/content/docs/concepts/workflow/retention.md Outdated Show resolved Hide resolved
engine/api/api.go Outdated Show resolved Hide resolved
engine/api/api.go Outdated Show resolved Hide resolved
yesnault
yesnault requested changes Oct 7, 2020
View reviewed changes
engine/api/workflow/init.go Outdated Show resolved Hide resolved
engine/api/workflow/init.go Outdated Show resolved Hide resolved
sdk/messages.go Outdated Show resolved Hide resolved
ui/src/assets/i18n/en.json Outdated Show resolved Hide resolved
ui/src/assets/i18n/en.json Outdated Show resolved Hide resolved
ui/src/assets/i18n/fr.json Show resolved Hide resolved
ui/src/assets/i18n/fr.json Show resolved Hide resolved
ui/src/assets/i18n/fr.json Show resolved Hide resolved
ui/src/assets/i18n/fr.json Show resolved Hide resolved
ui/src/assets/i18n/fr.json Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 7, 2020

CDS Report build-all-cds#14639.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

fsamin
fsamin requested changes Oct 7, 2020
View reviewed changes
engine/api/api_routes.go Outdated Show resolved Hide resolved
engine/api/purge/purge_run.go Show resolved Hide resolved
engine/api/workflow/dao.go Show resolved Hide resolved
engine/sql/api/218_workflow_retention_policy.sql Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 7, 2020

CDS Report build-all-cds#14640.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sguiheux sguiheux requested a review from yesnault October 7, 2020 11:18
fsamin
fsamin requested changes Oct 7, 2020
View reviewed changes
engine/api/workflow_run_craft.go Outdated Show resolved Hide resolved
engine/api/workflow_run_craft.go Show resolved Hide resolved
engine/api/workflow_run_craft.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux requested a review from fsamin October 7, 2020 15:54
@sguiheux sguiheux merged commit 1830951 into master Oct 8, 2020
@sguiheux sguiheux deleted the retentionPolicy branch October 9, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt