Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add artifactory integration #5802

Merged
merged 8 commits into from May 5, 2021
Merged

feat: add artifactory integration #5802

merged 8 commits into from May 5, 2021

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 28, 2021

CDS Report build-all-cds#15977.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✘

fsamin
fsamin requested changes Apr 28, 2021
View reviewed changes
contrib/integrations/artifactory/artifactory.yml Outdated Show resolved Hide resolved
engine/api/workflow/dao.go Show resolved Hide resolved
engine/api/workflow/dao_workflow_integration.go Outdated Show resolved Hide resolved
engine/api/workflow/dao_workflow_integration.go Show resolved Hide resolved
engine/worker/internal/action/builtin_artifact_download.go Outdated Show resolved Hide resolved
engine/worker/internal/action/builtin_artifact_download.go Outdated Show resolved Hide resolved
sdk/exportentities/v2/workflow_test.go Show resolved Hide resolved
@sguiheux @fsamin
Apply suggestions from code review
efbd673 
Co-authored-by: François Samin <francois.samin@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 28, 2021

CDS Report build-all-cds#15978.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 28, 2021

CDS Report build-all-cds#15981.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2021

SonarCloud Quality Gate failed.

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

34.4% 34.4% Coverage
2.2% 2.2% Duplication

@sguiheux sguiheux merged commit d993fac into master May 5, 2021
@sguiheux sguiheux deleted the artifactoryInt branch May 20, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt