Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow lazy binary download #5915

Merged
merged 9 commits into from Sep 2, 2021
Merged

feat: allow lazy binary download #5915

merged 9 commits into from Sep 2, 2021

Conversation

yesnault
Copy link
Member

@yesnault yesnault commented Sep 1, 2021

if there is no binary in docker image, there will be auto downloaded
from github or artifactory if configured.

Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@yesnault
feat: allow lazy binary download
c14c035 
if there is no binary in docker image, there will be auto downloaded
from github or artifactory if configured.

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 1, 2021

CDS Report build-all-cds#16373.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✘

sguiheux
sguiheux requested changes Sep 1, 2021
View reviewed changes
engine/api/download/download.go Show resolved Hide resolved
engine/api/download/download.go Outdated Show resolved Hide resolved
fsamin
fsamin requested changes Sep 1, 2021
View reviewed changes
engine/api/api.go Outdated Show resolved Hide resolved
engine/api/download/download.go Show resolved Hide resolved
engine/api/download/download.go Outdated Show resolved Hide resolved
engine/api/download/download.go Show resolved Hide resolved
engine/ui/ui.go Outdated Show resolved Hide resolved
engine/ui/ui.go Outdated Show resolved Hide resolved
engine/ui/ui.go Show resolved Hide resolved
engine/api/api.go Outdated Show resolved Hide resolved
sdk/download.go Outdated Show resolved Hide resolved
sdk/version.go Outdated Show resolved Hide resolved
@yesnault @fsamin
Update engine/api/api.go
b146492 
Co-authored-by: François Samin <francois.samin@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 1, 2021

CDS Report build-all-cds#16380.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✘

@yesnault
fix: cr
b5d8d09 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 1, 2021

CDS Report build-all-cds#16381.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@yesnault
fix: cr
57b1463 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: cr
563f15c 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 1, 2021

CDS Report build-all-cds#16384.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 1, 2021

CDS Report build-all-cds#16385.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@yesnault
fix: cr
5e94a00 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
chore: go.sum
d9e081c 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 1, 2021

CDS Report build-all-cds#16387.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@yesnault
fix: ut
a375aaf 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2021

CDS Report build-all-cds#16389.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2021

CDS Report build-all-cds#16389.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2021

CDS Report build-all-cds#16389.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2021

CDS Report build-all-cds#16389.3 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✔

@yesnault
fix: it
85ffe32 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2021

CDS Report build-all-cds#16392.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2021

CDS Report build-all-cds#16392.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yesnault yesnault merged commit d5d094e into master Sep 2, 2021
@yesnault yesnault deleted the ye-dl branch October 20, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yesnault @ovh-cds @fsamin @sguiheux @richardlt