Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker,cdn): logs order #5939

Merged
merged 6 commits into from Sep 23, 2021
Merged

fix(worker,cdn): logs order #5939

merged 6 commits into from Sep 23, 2021

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Sep 17, 2021

fix(worker,cdn): logs order

  • read stdout and stderr in the same goroutine to avoid mixing logs
  • store the number of millisecond for each line of logs as score in redis and retrieve it in "Number" field from a log line in the UI

Signed-off-by: francois samin francois.samin@corp.ovh.com

@fsamin
fix(worker,cdn): logs order
6024a48 
 * read stdout and stderr in the same goroutine to avoid mixing logs
 * store the number of millisecond for each line of logs as score in redis and retrieve it in "Number" field from a log line in the UI

Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin
fix(cdn): handle number of ms for each log lines
177cc42 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 23, 2021

CDS Report build-all-cds#16527.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@fsamin
fix: unit tests
37b3f06 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 23, 2021

CDS Report build-all-cds#16528.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 23, 2021

CDS Report build-all-cds#16532.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@richardlt richardlt merged commit 947426a into master Sep 23, 2021
@fsamin fsamin deleted the fix/worker/logs_order branch September 24, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fsamin @ovh-cds @yesnault @sguiheux @richardlt