Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): refactor authentication drivers + manage github merge commit #6439

Merged
merged 12 commits into from
Feb 13, 2023
Merged

feat(api): refactor authentication drivers + manage github merge commit #6439

merged 12 commits into from
Feb 13, 2023

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Feb 2, 2023

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@sguiheux sguiheux changed the title feat: refactor authentication drivers + manage github merge commit feat(api): refactor authentication drivers + manage github merge commit Feb 2, 2023
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 2, 2023

CDS Report build-all-cds#18474.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 2, 2023

CDS Report build-all-cds#18474.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

yesnault
yesnault requested changes Feb 6, 2023
View reviewed changes
engine/api/user_link.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 6, 2023

CDS Report build-all-cds#18487.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

richardlt
richardlt requested changes Feb 8, 2023
View reviewed changes
engine/api/api.go Outdated Show resolved Hide resolved
engine/api/auth_consumer.go Outdated Show resolved Hide resolved
engine/api/auth_local.go Outdated Show resolved Hide resolved
engine/api/auth_test.go Outdated Show resolved Hide resolved
engine/api/link/gorp.go Outdated Show resolved Hide resolved
sdk/token.go Show resolved Hide resolved
engine/api/api_routes.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 13, 2023

CDS Report build-all-cds#18519.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 13, 2023

CDS Report build-all-cds#18520.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux merged commit 9e332b3 into master Feb 13, 2023
@sguiheux sguiheux deleted the mergeCommitGithub branch March 6, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt