Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace github.com/ghodss/yaml with github.com/rockbears/yaml #6501

Merged
merged 2 commits into from
Jun 1, 2023
Merged

refactor: replace github.com/ghodss/yaml with github.com/rockbears/yaml #6501

merged 2 commits into from
Jun 1, 2023

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Mar 9, 2023

The package github.com/ghodss/yaml is no longer actively maintained. See discussion in ghodss/yaml#75 and ghodss/yaml#80. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml.

The notable change is that github.com/ghodss/yaml uses gopkg.in/yaml.v2 v2.2.2, but sigs.k8s.io/yaml uses gopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.

EDIT: Replace github.com/ghodss/yaml with github.com/rockbears/yaml

@sguiheux
Copy link
Collaborator

Hi, we already started to use a new yaml lib: https://github.com/rockbears/yaml that use yaml.v3

At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Reference: #6501 (comment)
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@Juneezee Juneezee changed the title refactor: replace github.com/ghodss/yaml with sigs.k8s.io/yaml refactor: replace github.com/ghodss/yaml with github.com/rockbears/yaml Mar 24, 2023
@Juneezee
Copy link
Contributor Author

@sguiheux Please take a look again. Thank you ❤️

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 24, 2023

CDS Report build-all-cds#18693.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 24, 2023

CDS Report build-all-cds#18693.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 24, 2023

CDS Report build-all-cds#18693.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 3, 2023

CDS Report build-all-cds#18693.3 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✘

@Juneezee
Copy link
Contributor Author

Hi @fsamin @sguiheux . I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago.

I would be grateful if you could take some time to review the changes and provide me with your feedback. If there are any specific concerns or questions you have about the changes, I am more than willing to help address them.

Thank you for your time and consideration. I truly appreciate it. ❤️

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 31, 2023

CDS Report build-all-cds#18851.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@yesnault yesnault changed the base branch from master to ye-rockbears_yaml June 1, 2023 14:41
@yesnault
Copy link
Member

yesnault commented Jun 1, 2023

I merge that on a another branch, to fix some go.mod lines

@yesnault yesnault merged commit 507cce0 into ovh:ye-rockbears_yaml Jun 1, 2023
1 check failed
yesnault added a commit that referenced this pull request Jun 14, 2023
* refactor: replace yaml lib (#6501)

* refactor: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml`

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Co-authored-by: Eng Zer Jun <engzerjun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants