Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request - Add celebrities #25

Closed
mohammad-taheri1 opened this issue Feb 21, 2023 · 5 comments
Closed

Request - Add celebrities #25

mohammad-taheri1 opened this issue Feb 21, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@mohammad-taheri1
Copy link

Hi.

Is there any way to add celebrities to resources?

It would be beneficial.

Let me know if it is possible. I will create them and send PR.
@Ovi Ovi added the enhancement New feature or request label Feb 21, 2023
@Ovi
Copy link
Owner

Ovi commented Feb 21, 2023

PRs are always welcome 😉

@mohammad-taheri1
Copy link
Author

Good to hear that. What should we do for their avatar image?

@Ovi
Copy link
Owner

Ovi commented Feb 21, 2023

We can:

  1. use their Wikimedia link if available.
  2. Some royalty-free images from the internet (in this case, I will upload all the provided images to i.dummyjson.com)

@typeof-username
Copy link

@mohammad-taheri1 which celebrities are you planning to add?

@Ovi
Copy link
Owner

Ovi commented Jun 2, 2023

Closing this due to inactivity, feel free to reopen it when required,

@Ovi Ovi closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ovi @mohammad-taheri1 @typeof-username