Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovirt_vm module Add storage_error_resume_behaviour Switch #694

Closed
hemak88 opened this issue Mar 16, 2023 · 6 comments
Closed

ovirt_vm module Add storage_error_resume_behaviour Switch #694

hemak88 opened this issue Mar 16, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@hemak88
Copy link
Contributor

hemak88 commented Mar 16, 2023

SUMMARY

ovirt_vm ansible module is missing storage_error_resume_behaviour switch parameter.
The feature to choose VM state for HA is available in Ovirt GUI. So same feature if available in ansible makes it more powerful and flexible.
It will be great to have that feature because it can enable choosing the VM state to be in when a hardware or storage issue happens

COMPONENT NAME

ovirt_vm
https://docs.ansible.com/ansible/2.9/modules/ovirt_vm_module

ADDITIONAL INFORMATION

Example usage once the feature is added:
ovirt_vm:
storage_error_resume_behaviour:
options: "Auto Resume" | "Leave Paused" | "Kill"
Restart required for VM (apply with restart)

@hemak88 hemak88 added the enhancement New feature or request label Mar 16, 2023
@hemak88
Copy link
Contributor Author

hemak88 commented Jun 22, 2023

Any update on this

@hemak88
Copy link
Contributor Author

hemak88 commented Sep 6, 2023

Can we add this feature please?

@michalskrivanek
Copy link
Member

Hi, no one is actively working on new features in the module, if you propose a patch and verify it we can still include it, but it's unlikely someone else would pick it up

@hemak88
Copy link
Contributor Author

hemak88 commented Sep 8, 2023

Hi @michalskrivanek , I have patch for this which I tested in my lab, Can we add this to the module. How should I go ahead with Pull request creation

@mnecas
Copy link
Member

mnecas commented Sep 8, 2023

If you have some patch please post the PR and I'll check it out. Please also sign the commit with 'git commit -s'.

@hemak88
Copy link
Contributor Author

hemak88 commented Sep 8, 2023

I have raised a patch. Kindly review @mnecas
#721

@mnecas mnecas closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants