Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'container' argument from CentralNode, WorkerNode, RelayNode constructors. #181

Open
dceara opened this issue Oct 4, 2023 · 1 comment

Comments

@dceara
Copy link
Collaborator

dceara commented Oct 4, 2023

As @mkalcok points out these arguments give the wrong impression that users can choose random names. That's not exactly true. Container names are either (partially) hardcoded in ovn-fake-multinode or can be changed via config. It's probably better to pass the config (and maybe an index or some other unique id) and do the container naming internally.

@dceara
Copy link
Collaborator Author

dceara commented Oct 4, 2023

Originally reported at: #180 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant