Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGS: Revisit the log levels in OVNK code #3183

Open
tssurya opened this issue Sep 27, 2022 · 1 comment
Open

LOGS: Revisit the log levels in OVNK code #3183

tssurya opened this issue Sep 27, 2022 · 1 comment

Comments

@tssurya
Copy link
Member

tssurya commented Sep 27, 2022

As seen here #3166 and in a few other place, we have two issues:

  1. We need to be strict about what's at level 5 and what's below that, adding too much logs can make it difficult to catch the important logs while adding too less logs can make it hard to debug. There needs to be a balance.
  2. nbctl logs were smaller than the libovsdb transact logs, as a result in real deployments we see log rotation happening very fast and there is a limit to number of log files stored on nodes from a specific pod. -> we need to make an effort to reduce the log size as much as possible.
@tssurya
Copy link
Member Author

tssurya commented Sep 27, 2022

One idea that @kyrtapz had was to remove all nil fields in the transact and configure logs, since they anyways don't provide any useful info and they can cut down the size of a single transact line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant