Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EIP node update event handling better #4361

Open
tssurya opened this issue May 15, 2024 · 0 comments
Open

Make EIP node update event handling better #4361

tssurya opened this issue May 15, 2024 · 0 comments
Labels
area/code-cleanup Issues related to code clean ups, FUPs, refactors, addressing review comments in FUPs

Comments

@tssurya
Copy link
Member

tssurya commented May 15, 2024

What is this issue about?

See #4265 (comment) for details
But TL;DR is that there are occassions when we don't want to do extra computing for every node update then coupling that together with say the fact that node updates for two different nodes in two different threads can happen in parallel that try to create the same ovn constructs can also cause race issues. In the past we have solved this using (1) waitops hack 2) mutexes 3) OVNK specific caches like what @trozet ^ is suggesting above 4) ensuring we call the create from a global space and avoid the threads racing all together if possible

I went with 2 for now, but probably 3 is the better way to do specially if in the future we have more cases like we do in case of node events.

@tssurya tssurya added the area/code-cleanup Issues related to code clean ups, FUPs, refactors, addressing review comments in FUPs label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-cleanup Issues related to code clean ups, FUPs, refactors, addressing review comments in FUPs
Projects
None yet
Development

No branches or pull requests

1 participant