detect if the cluster has endpoint slices #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the endpoint slice controller was checking if the kubernetes version was greater than 1.20 in order to run, so it can verify the dual-stack api was implemented. Since the endpoint slice controller in ovn can run with or without the dualstack api, we only need to check that the API for slices is enabled. Signed-off-by: Antonio Ojea <aojea@redhat.com>
trozet
reviewed
Feb 16, 2021
| func UseEndpointSlices(kubeClient kubernetes.Interface) bool { | ||
| endpointSlicesEnabled := false | ||
| if _, err := kubeClient.Discovery().ServerResourcesForGroupVersion(discovery.SchemeGroupVersion.String()); err == nil { |
There was a problem hiding this comment.
just so I remember in the future. This works because it pulls the client's scheme version and then queries the server to check if it supports whats in the client's schema (and obviously our client has support for endpoint slices).
|
hmm some network policy flakes and this flaked 5x: https://github.com/ovn-org/ovn-kubernetes/pull/2049/checks?check_run_id=1912398180 |
|
/retest |
IIRC that is a very resource intensive and complex test, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detection of the kubernetes version fails in the CI, because the library doesn't parse minors versions that are not only numbers, i.e v1.21.0-alpha.1, that are typically all the clusters that run in the CI.
We really don't need to check the kubernetes version, because the controller can work without dual-stack , it only needs that the cluster has endpoint slices enabled.