Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to v0.40.0 #1016

Merged
merged 2 commits into from Jan 12, 2021
Merged

Update SDK to v0.40.0 #1016

merged 2 commits into from Jan 12, 2021

Conversation

akhilkumarpilli
Copy link
Contributor

No description provided.

@hydrogen18
Copy link
Contributor

I think to get the tests to pass you'll need to be on a version of cosmos that has this fix btw:

cosmos/cosmos-sdk#8225

@akhilkumarpilli akhilkumarpilli changed the title Update SDK to v0.40.0-rc5 Update SDK to v0.40.0-rc6 Jan 7, 2021
@boz
Copy link
Contributor

boz commented Jan 11, 2021

Can we go straight to 0.40.0 now?

@akhilkumarpilli akhilkumarpilli changed the title Update SDK to v0.40.0-rc6 Update SDK to v0.40.0 Jan 11, 2021
@boz
Copy link
Contributor

boz commented Jan 12, 2021

The failing test looks like something that's easy to fix; let's try to get this merged asap @akhilkumarpilli

@boz boz mentioned this pull request Jan 12, 2021
12 tasks
@akhilkumarpilli
Copy link
Contributor Author

The failing test looks like something that's easy to fix; let's try to get this merged asap @akhilkumarpilli

Actually there is some issue with sdk.Coin. It is accepting decimals and normalizing it into integer. But when you compare normalized integer with expected integer, there hash values are different.

@boz
Copy link
Contributor

boz commented Jan 12, 2021

I see that @akhilkumarpilli , but I think that we should expect that case to fail. That is how it looks on my branch, at least.

https://github.com/ovrclk/akash/blob/c6cf3e02e88809dc990ec2945301f766a8402df4/sdl/coin_test.go#L19-L31

@akhilkumarpilli akhilkumarpilli marked this pull request as ready for review January 12, 2021 06:24
@akhilkumarpilli
Copy link
Contributor Author

Yeah, but now it's not throwing error. Before, it used to throw error when we sent decimals as input. That's the reason, we expect it should be fail.

@boz
Copy link
Contributor

boz commented Jan 12, 2021

I see, okay.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1016 (d67d27a) into master (51cad69) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   84.00%   84.29%   +0.29%     
==========================================
  Files           6        6              
  Lines         425      433       +8     
==========================================
+ Hits          357      365       +8     
  Misses         64       64              
  Partials        4        4              

@boz boz merged commit 383eda0 into master Jan 12, 2021
@boz boz deleted the akhil/update-sdk branch January 12, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants