New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK to v0.40.0 #1016
Update SDK to v0.40.0 #1016
Conversation
ca61969
to
9643088
Compare
9643088
to
d2bbcdb
Compare
I think to get the tests to pass you'll need to be on a version of cosmos that has this fix btw: |
ada587c
to
d42b0a1
Compare
d42b0a1
to
5305ed8
Compare
Can we go straight to |
5305ed8
to
4290b4e
Compare
The failing test looks like something that's easy to fix; let's try to get this merged asap @akhilkumarpilli |
Actually there is some issue with |
I see that @akhilkumarpilli , but I think that we should expect that case to fail. That is how it looks on my branch, at least. |
Yeah, but now it's not throwing error. Before, it used to throw error when we sent decimals as input. That's the reason, we expect it should be fail. |
I see, okay. |
4290b4e
to
1f1b453
Compare
1f1b453
to
d046f82
Compare
refs #1027
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
==========================================
+ Coverage 84.00% 84.29% +0.29%
==========================================
Files 6 6
Lines 425 433 +8
==========================================
+ Hits 357 365 +8
Misses 64 64
Partials 4 4 |
No description provided.