Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to close bid when bid state is open #676

Merged
merged 5 commits into from Jun 19, 2020
Merged

Allow to close bid when bid state is open #676

merged 5 commits into from Jun 19, 2020

Conversation

akhilkumarpilli
Copy link
Contributor

Fixes #647

@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited

Codecov Report

Merging #676 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   30.91%   30.96%   +0.05%     
==========================================
  Files         144      144              
  Lines        6858     6863       +5     
==========================================
+ Hits         2120     2125       +5     
  Misses       4632     4632              
  Partials      106      106
Impacted Files Coverage Δ
x/market/handler/handler.go 97.14% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f291c4...1c81df3. Read the comment docs.

@akhilkumarpilli akhilkumarpilli marked this pull request as ready for review June 18, 2020 12:20
@akhilkumarpilli akhilkumarpilli requested a review from boz June 18, 2020 12:20
boz
boz reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@boz boz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you. Add some tests for this case?

boz
boz approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@boz boz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@boz boz merged commit a4bcbbc into master Jun 19, 2020
@boz boz deleted the akhil/close-opened-bid branch June 19, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boz boz boz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@akhilkumarpilli @boz