Improve validation of address with VerifyAddressFormat

[akhilkumarpilli]

Fixes #571

[codecov]

Codecov Report

Merging #677 into master will decrease coverage by 0.08%.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
- Coverage   30.99%   30.91%   -0.09%     
==========================================
  Files         144      144              
  Lines        6849     6858       +9     
==========================================
- Hits         2123     2120       -3     
- Misses       4620     4632      +12     
  Partials      106      106              

Impacted Files	Coverage Δ
x/deployment/query/path.go	31.91% <0.00%> (-1.42%)	⬇️
x/deployment/query/types.go	0.00% <ø> (ø)
x/deployment/types/id.go	48.14% <0.00%> (-1.86%)	⬇️
x/deployment/types/msgs.go	0.00% <0.00%> (ø)
x/market/query/path.go	17.24% <0.00%> (-1.28%)	⬇️
x/market/types/id.go	61.11% <0.00%> (ø)
x/market/types/msgs.go	0.00% <0.00%> (ø)
x/provider/types/msgs.go	76.59% <100.00%> (-6.39%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aacaf3...cb95c67. Read the comment docs.

[boz]

Looking great, thank you.

Can you make sure that there's adequate test coverage for the message validations?

See my note about the filters - I think that they can probably be left out of this PR. The semantics of querying should be:

1. if the address is empty, don't filter on address
2. if the address is non-empty and invalid, return an error
3. if the address is non-empty and valid, filter on the address

[akhilkumarpilli]

Looking great, thank you.

Can you make sure that there's adequate test coverage for the message validations?

See my note about the filters - I think that they can probably be left out of this PR. The semantics of querying should be:

1. if the address is empty, don't filter on address

2. if the address is non-empty and invalid, return an error

3. if the address is non-empty and valid, filter on the address

Added few more cli tests for testing filters. Also verifying given owner address and if invalid, throwing error.

This function will not change as I am validating given owner address before coming to this function.

[boz]

This function will not change as I am validating given owner address before coming to this function.

Perfect, thank you.

[boz]

🚀