Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stringer for static type conversions #688

Merged
merged 6 commits into from Jun 22, 2020
Merged

Use stringer for static type conversions #688

merged 6 commits into from Jun 22, 2020

Conversation

akhilkumarpilli
Copy link
Contributor

@akhilkumarpilli akhilkumarpilli commented Jun 20, 2020 •
edited

Fixes #665

@codecov
Copy link

codecov bot commented Jun 20, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@2d05f5b). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #688   +/-   ##
=========================================
  Coverage          ?   30.72%           
=========================================
  Files             ?      147           
  Lines             ?     6965           
  Branches          ?        0           
=========================================
  Hits              ?     2140           
  Misses            ?     4717           
  Partials          ?      108
Impacted Files Coverage Δ
cmd/statik/statik.go 100.00% <ø> (ø)
x/deployment/client/cli/flags.go 0.00% <0.00%> (ø)
x/deployment/types/autogen_stringer.go 0.00% <0.00%> (ø)
x/deployment/types/types.go 76.19% <ø> (ø)
x/market/client/cli/flags.go 0.00% <0.00%> (ø)
x/market/types/autogen_stringer.go 0.00% <0.00%> (ø)
x/market/types/types.go 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d05f5b...1aabeb3. Read the comment docs.

@akhilkumarpilli akhilkumarpilli marked this pull request as ready for review June 20, 2020 11:53
@akhilkumarpilli akhilkumarpilli requested a review from boz June 20, 2020 11:53
boz
boz requested changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@boz boz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akhilkumarpilli! I left a couple of comments inline.

x/deployment/types/types.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
x/market/types/state.go Outdated Show resolved Hide resolved
x/market/types/types.go Outdated Show resolved Hide resolved
boz
boz approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@boz boz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🚀 🚢

@boz
Copy link
Contributor

boz commented Jun 22, 2020

I'd like to merge this shortly @Ropes @troian; please take a look if you can.

@boz boz merged commit ec31a6c into master Jun 22, 2020
@boz boz deleted the akhil/use-stringer branch June 22, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boz boz boz approved these changes

@Ropes Ropes Awaiting requested review from Ropes

@troian troian Awaiting requested review from troian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@akhilkumarpilli @boz