configure mainnet using build tags #700
Conversation
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
==========================================
+ Coverage 30.41% 30.82% +0.40%
==========================================
Files 147 149 +2
Lines 7020 7063 +43
==========================================
+ Hits 2135 2177 +42
- Misses 4776 4778 +2
+ Partials 109 108 -1
Continue to review full report at Codecov.
|
|
@akhilkumarpilli looks good, file namings are bit odd. Lets think of different namings. How about |
| ), | ||
|
|
||
| provider.NewAppModule(app.keeper.provider, app.keeper.bank, app.keeper.market), | ||
| ) |
There was a problem hiding this comment.
same here. for instance, does ModuleManager have an AppendModule() function or something that can be used in the tag-specific functions?
There was a problem hiding this comment.
I am not able to find a way to append modules in ModuleManager. Tried to reduce the amount of duplicate code and left with these.
There was a problem hiding this comment.
hmm, how about
app.mm = module.NewManager(
genutil.NewModule(),
// ...
app.createAkashModules()...,
)
// ...
func (app *App) createAkashModules() []sdk.AppModule {
// ...
}or even
module.NewManager(app.createAppModules()...)
//...
func (app *App) createAppModules() []sdk.AppModules {
return append(app.createCoreAppModules(),app.createAkashAppModules()...)
}
func (app *App) createCoreModulesBase() []sdk.AppModules {
return []sdk.AppModule{
}
}
// mainnet version:
func (app *App) createAkashAppModules() []sdk.AppModule {
return []sdk.AppModule{}
}
// !mainnet version
func (app *App) createAkashAppModules() []sdk.AppModule {
return []sdk.AppModule{
deployment.NewAppModule(),
// ...
}
}
If we rename files to |
| ), | ||
|
|
||
| provider.NewAppModule(app.keeper.provider, app.keeper.bank, app.keeper.market), | ||
| ) |
There was a problem hiding this comment.
hmm, how about
app.mm = module.NewManager(
genutil.NewModule(),
// ...
app.createAkashModules()...,
)
// ...
func (app *App) createAkashModules() []sdk.AppModule {
// ...
}or even
module.NewManager(app.createAppModules()...)
//...
func (app *App) createAppModules() []sdk.AppModules {
return append(app.createCoreAppModules(),app.createAkashAppModules()...)
}
func (app *App) createCoreModulesBase() []sdk.AppModules {
return []sdk.AppModule{
}
}
// mainnet version:
func (app *App) createAkashAppModules() []sdk.AppModule {
return []sdk.AppModule{}
}
// !mainnet version
func (app *App) createAkashAppModules() []sdk.AppModule {
return []sdk.AppModule{
deployment.NewAppModule(),
// ...
}
}| deployment.ModuleName, | ||
| provider.ModuleName, | ||
| market.ModuleName, | ||
| ) |
| deployment.NewAppModuleSimulation(app.keeper.deployment, app.keeper.acct), | ||
| market.NewAppModuleSimulation(app.keeper.market, app.keeper.acct, app.keeper.deployment, | ||
| app.keeper.provider, app.keeper.bank), | ||
| provider.NewAppModuleSimulation(app.keeper.provider, app.keeper.acct), |
|
sorry @akhilkumarpilli I forgot to merge this. |
Fixes #683