fix: adjust MaxGroupMemPrice #704
Conversation
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
=======================================
Coverage 30.91% 30.91%
=======================================
Files 144 144
Lines 6916 6916
=======================================
Hits 2138 2138
Misses 4670 4670
Partials 108 108
Continue to review full report at Codecov.
|
validation/config.go
Outdated
|
|
||
| if defaultConfig.MaxGroupMemPrice < minDefaultMaxGroupMemPrice { | ||
| panic("invalid max group memory price") | ||
| } |
There was a problem hiding this comment.
let's not do this. i agree with the sentiment but we should handle it more gracefully. probably need to refactor the way this validation works - it was added in a rush to make a (2018) testnet more user-friendly.
just skip it for now
There was a problem hiding this comment.
fmt.Println instead of panic?
There was a problem hiding this comment.
everything still works fine with a lower value, right? it's just that the prices are lower than we'd like.
if total amount of memory in group less then 1G
calculatePriceRange will always return range 0..1.
fixes #640 ?
Signed-off-by: Artur Troian <troian.ap@gmail.com>
if total amount of memory in group less then 1G
calculatePriceRange will always return range 0..1.
fixes #640 ?