Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare market bid errors as sdkerror #706

Merged
merged 1 commit into from Jun 24, 2020
Merged

fix: declare market bid errors as sdkerror #706

merged 1 commit into from Jun 24, 2020

Conversation

troian
Copy link
Member

@troian troian commented Jun 24, 2020

fixes #702

result

{
  "height": "301",
  "txhash": "5690F8A18FA254243D94B466ABAABF7437D80FA8EE43E71008596BF2CE9E527C",
  "codespace": "market",
  "code": 20,
  "raw_log": "order closed: failed to execute message; message index: 0",
  "gas_wanted": "200000",
  "gas_used": "36491"
}

fixes #702

Signed-off-by: Artur Troian <troian.ap@gmail.com>
@troian troian requested review from boz and Ropes as code owners June 24, 2020 19:48
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #706 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #706   +/-   ##
=======================================
  Coverage   30.87%   30.87%           
=======================================
  Files         144      144           
  Lines        6916     6916           
=======================================
  Hits         2135     2135           
  Misses       4672     4672           
  Partials      109      109           
Impacted Files Coverage Δ
x/market/types/types.go 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2ce2d...5091e81. Read the comment docs.

Copy link
Contributor

@boz boz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🚢

@troian troian merged commit b34b90c into master Jun 24, 2020
@troian troian deleted the issue-702 branch June 24, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants