Kustomize provisioning Provider updates #910

Ropes · 2020-11-12T23:38:21Z

~~Hold off on reviewing until after CI runs~~

Documentation updates for running a provider with kustomize configuration, running testing through the _run/single environment. Main problem was debugging our CLI situation which @hydrogen18 discovered is probably related to the methods used to access command flags.

akashctl -> akash binary(cleanup of old references)
akt -> uakt
Kubernetes upgraded to 1.19+ (_run/single)
Corrected akash params for configuration commands
Utilize local directories for kustomization files
Major change uses the cli flags to akash provider to pass
configuration.
Running akash node name: akashd -> akash-node
Ingress accessible via: akash.localhost

fixes: https://github.com/ovrclk/akash/issues/909

_docs/examples/provider/README.md

boz

looks awesome

_docs/examples/provider/README.md

_docs/examples/provider/kustomization.yaml

boz · 2020-11-16T10:34:35Z

_docs/kustomize/akash-provider/kustomization.yaml

@@ -19,7 +19,7 @@ configMapGenerator:
    literals:
      - home=/home
      - from=main
-      - node=tcp://akashd:26657
+      - node=http://akashd:26657


no longer tcp://?

New sdk changes... seems like a weird config artifact that might get flipped back.

_docs/provider.yaml

_run/common-kind.mk

boz · 2020-11-16T10:37:48Z

_run/single/kind-config.yaml

@@ -2,6 +2,7 @@ kind: Cluster
 apiVersion: kind.x-k8s.io/v1alpha4
 nodes:
 - role: control-plane
+  image: kindest/node:v1.19.1@sha256:98cf5288864662e37115e362b23e4369c8c4a408f99cbc06e58ac30ddc721600


can you use just v1.19.1?

Following the kind docs. They suggest including the sha sum.

boz · 2020-11-17T12:57:08Z

_docs/examples/provider/README.md

-export AKASHCTL_CHAIN_ID=testnet-v4
+export AKASH_NODE=tcp://rpc-edgenet.akashdev.net:26657
+export AKASH_CHAIN_ID=edgenet
+export AKASH_KEYRING_BACKEND=test


Are these not read from the environment later on? I see the flags are used everywhere.

hydrogen18 · 2020-11-17T14:00:23Z

@boz the way that cosmos SDK is built it is mandatory to set --chain-id on the command line

boz · 2020-11-17T14:15:14Z

@hydrogen18 what about these? if not, is the idea to just keep it consistent for now?

--keyring-backend
--home
--node

It's really a bummer. Maybe there are some quickfix solutions #908

hydrogen18 · 2020-11-17T18:37:54Z

For now the easiest solution is to just specify it everywhere, including examples so anyone looking at them nows to set them. In the kustomize scripts we can do stuff like --chain-id=$AKASH_CHAIN_ID to work around this until we fix it.

Ropes · 2020-11-17T22:37:07Z

Yeah I'm going to second @hydrogen18, the envvar configuration doesn't work, the required flag burns us. For now unfortunately this verbose CLI configuration is the only way.

To make it messier, we can't just set a flag like --keyring-backend on every command, because the CLI will throw an error if it's supplied to a command which does not consume it.

boz · 2020-11-18T03:37:22Z

In the kustomize scripts we can do stuff like --chain-id=$AKASH_CHAIN_ID to work around this until we fix it.

That's what is being done in the guide right now.

Yeah I'm going to second @hydrogen18, the envvar configuration doesn't work, the required flag burns us. For now unfortunately this verbose CLI configuration is the only way.

Again, it's only for --chain-id, right?

To make it messier, we can't just set a flag like --keyring-backend on every command, because the CLI will throw an error if it's supplied to a command which does not consume it.

It's not even being set on all key commands right now (see the export section).

Anyways, was any progress made on this today?

Ropes · 2020-11-19T22:32:27Z

I need to rebase this, but otherwise are we good to merge?

* `akash` binary documentation cleanup. * `akashctl` -> `akash` binary * `akt` -> `uakt` Upgrade kustomize configuration for Kubernetes 1.19 * Corrected `akash` params for configuration commands * Utilize local directories for kustomization files * Cleanup akash relevant namespaces with Make. * Functional _run/single: akash + provider * Major change uses the cli flags to `akash provider` to pass configuration. * Kustomize: rename Deployment/Ingress `akashd` -> `akash-node` * akash-node URL: akash.localhost (updated Makefiles) * Updated documentation * k8s internal service `akashd` -> `akash-node` fixes: https://github.com/ovrclk/akash/issues/909 Signed-off-by: Josh Roppo <josh@akash.network>

hydrogen18 · 2020-11-13T13:09:55Z

_docs/examples/provider/README.md

 ```

 ### Configure Kubernetes Akash Namespace

 Create the `akash-services` namespace for running Provider.

 ```sh
-kubectl apply -f https://raw.githubusercontent.com/ovrclk/akash/master/_docs/kustomize/namespace.yaml
+kubectl apply -f https://raw.githubusercontent.com/ovrclk/akash/master/_docs/kustomize/networking/namespace.yaml


I think we should reference this from the filesystem, rather than this document. Otherwise a user could get master which may have diverged.

I tend to agree with your point, however this namespace.yaml might be one of the few exceptions since it probably won't ever change.

For example files like deployment.yaml, or kustomization.yaml which will have version specific changes, are more fragile to break referencing master.

Ropes requested review from boz and troian as code owners November 12, 2020 23:38

hydrogen18 reviewed Nov 13, 2020

View reviewed changes

_docs/examples/provider/README.md Outdated Show resolved Hide resolved

Ropes force-pushed the ropes/provider-updates branch 2 times, most recently from 400dd80 to b97b226 Compare November 13, 2020 22:41

boz reviewed Nov 16, 2020

View reviewed changes

Ropes force-pushed the ropes/provider-updates branch 2 times, most recently from 52fb904 to 59bf7a7 Compare November 16, 2020 20:29

boz reviewed Nov 17, 2020

View reviewed changes

boz approved these changes Nov 19, 2020

View reviewed changes

Ropes force-pushed the ropes/provider-updates branch from 59bf7a7 to ec7fd65 Compare November 20, 2020 22:29

hydrogen18 reviewed Nov 20, 2020

View reviewed changes

hydrogen18 approved these changes Nov 21, 2020

View reviewed changes

Ropes merged commit cc01f0e into master Nov 21, 2020

boz deleted the ropes/provider-updates branch April 3, 2021 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kustomize provisioning Provider updates #910

Kustomize provisioning Provider updates #910

Ropes commented Nov 12, 2020 •

edited

boz left a comment

boz Nov 16, 2020

Ropes Nov 16, 2020

boz Nov 16, 2020

Ropes Nov 16, 2020

boz Nov 17, 2020

hydrogen18 commented Nov 17, 2020

boz commented Nov 17, 2020

hydrogen18 commented Nov 17, 2020

Ropes commented Nov 17, 2020

boz commented Nov 18, 2020

Ropes commented Nov 19, 2020

hydrogen18 Nov 13, 2020

Ropes Nov 20, 2020

Kustomize provisioning Provider updates #910

Kustomize provisioning Provider updates #910

Conversation

Ropes commented Nov 12, 2020 • edited

boz left a comment

Choose a reason for hiding this comment

boz Nov 16, 2020

Choose a reason for hiding this comment

Ropes Nov 16, 2020

Choose a reason for hiding this comment

boz Nov 16, 2020

Choose a reason for hiding this comment

Ropes Nov 16, 2020

Choose a reason for hiding this comment

boz Nov 17, 2020

Choose a reason for hiding this comment

hydrogen18 commented Nov 17, 2020

boz commented Nov 17, 2020

hydrogen18 commented Nov 17, 2020

Ropes commented Nov 17, 2020

boz commented Nov 18, 2020

Ropes commented Nov 19, 2020

hydrogen18 Nov 13, 2020

Choose a reason for hiding this comment

Ropes Nov 20, 2020

Choose a reason for hiding this comment

Ropes commented Nov 12, 2020 •

edited