Skip to content

Commit

Permalink
ovs-lib: Add timeout at ovs-check-dead-ifs.
Browse files Browse the repository at this point in the history
At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read
an entry in /proc/<pid>/fd/<some fd> but hangs forever.  The pid is
a qemu-system-x86_64 process and we suspect it's an issue related to
qemu, not ovs.  As a result, force-reload-kmod hangs and OVS bridge
never gets restarted. This patch adds a timeout of 5-seconds to
ovs-check-dead-ifs.

VMware-BZ: #2408059
Signed-off-by: William Tu <u9012063@gmail.com>
Cc: Ashish Varma <ashishvarma.ovs@gmail.com>
Cc: Gurucharan Shetty <guru@ovn.org>
Signed-off-by: 0-day Robot <robot@bytheb.org>
  • Loading branch information
williamtu authored and ovsrobot committed Aug 23, 2019
1 parent d578e06 commit 36e160b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion utilities/ovs-lib.in
Expand Up @@ -654,7 +654,7 @@ force_reload_kmod () {

restore_interfaces

"$datadir/scripts/ovs-check-dead-ifs"
timeout 5 "$datadir/scripts/ovs-check-dead-ifs"
}

## ------- ##
Expand Down

0 comments on commit 36e160b

Please sign in to comment.