Should throw an exception with thumb.time > video.length

[blaind]

I'm using the following thumbnail style: :thumb => { :geometry => '128x120', :format => 'jpg', :time => 5}

The problem is that thumbnail generation silently fails for videos that are less than 5 seconds in length, producing a thumbnail that is zero bytes in length.

Should there be either a raised exception, or retry for thumbnail generation for example from the beginning of video?

[owahab]

Retrying the thumbnail from the beginning is not an expected behavior.
Throwing an exception might be a better idea.

[owahab]

Updating title.

[jebw]

Whilst I can see why throwing a exception is the 'correct' behaviour - in real terms, what can you do a that point. You catch the exception, but you still don't have a means to create the thumbnail from a different point.

The following commit checks the length of the video, if its too short, then it just grabs a frame from the middle of the video (this is better than the start since some videos will begin with a black screen).

jebw@fcaaf40

This should at least result in a usable thumbnail.

[owahab]

@jebw not really. Because you might end up grabbing a black frame.

[attenzione]

please, review my comment in another issue, this is easy implemented solution #48 (comment)

[owahab]

This project has been deprecated in favor of paperclip-av-transcoder.