Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Storage Algorithms 2.4.1 revisited #1975

Closed
jmanico opened this issue Jun 5, 2024 · 3 comments
Closed

Password Storage Algorithms 2.4.1 revisited #1975

jmanico opened this issue Jun 5, 2024 · 3 comments
Assignees

Comments

@jmanico
Copy link
Member

jmanico commented Jun 5, 2024

We once had specific password storage requirements. While those were removed, I believe including guidance on using a strong, modern password hashing algorithm like Argon2id would be very beneficial to developers.

Argon2id is a widely recommended choice due to its dynamic configuration capability and projected longevity. It would encourage developers to adopt a best-in-class approach for password security.

Therefore, I propose adding a requirement similar to this:

[MODIFIED, MERGED FROM 2.4.3, 2.4.4] Verify that user passwords are stored using an approved password hashing algorithm, such as Argon2id, that is securely configured according to current guidance.

This aligns well with the high-level goals of ASVS 2.4.1 while offering more specific guidance for developers.

@jmanico
Copy link
Member Author

jmanico commented Jun 6, 2024

I also like @elarlang suggestion from #1812 (comment) if that is still valid.

@elarlang
Copy link
Collaborator

elarlang commented Jun 6, 2024

I also like @elarlang suggestion from #1812 (comment) if that is still valid.

It is not valid anymore, as discussed and decided here #1923 (comment) and commited here 76268ea

@tghosth
Copy link
Collaborator

tghosth commented Jun 11, 2024

Yeah we had a lot of back and forth on this and the current position is how we decided.

Argon2id is mentioned in the very first bullet of the password storage cheatsheet tl;dr which is what we refer to.

If you don't mind, I will close this as a done deal for now.

@tghosth tghosth closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants