Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page 31 - The Malicious Code Section wording as a bit difficult to read, wordy #23

Closed
defern opened this issue Nov 20, 2014 · 1 comment
Assignees
Milestone

Comments

@defern
Copy link
Collaborator

defern commented Nov 20, 2014

Page 31 - The Malicious Code Section wording as a bit difficult to read, wordy

We should try to use positive wording

Examples:

V13.1 Verify that no malicious code is in any code that was either developed or modified in order to create the application.
V13.3 Verify that all code implementing or using authentication controls is not affected by any malicious code.
V13.6 Verify that all input validation controls are not affected by any malicious code.
V13.7 Verify that all code implementing or using output validation controls is not affected by any malicious code.

Possible Solutions:

13.1 Verify that the code used to develop or create the application is free of malicious code.

13.3 Verify that malicious code cannot affect code that implements or uses authentication controls

13.6 Verify that malicious code cannot affect input validation controls.

13.7 Verify that malicious code cannot affect code that implements or uses output validation controls.

“Affect” may be changed to, “interact with” or “impact”

@vanderaj vanderaj added this to the 2.1 milestone Nov 20, 2014
@vanderaj vanderaj added bug and removed bug labels Nov 20, 2014
@vanderaj vanderaj modified the milestone: 2.1 Nov 21, 2014
@vanderaj vanderaj added enhancement and removed bug labels Nov 21, 2014
@vanderaj vanderaj modified the milestone: 2.1 Nov 21, 2014
@vanderaj vanderaj self-assigned this Mar 3, 2015
@vanderaj
Copy link
Member

Hi there,

We have completely re-vamped the malicious code section, replacing it with a single Level 3 control:

"Verify that a code review looks for malicious code, back doors, easter eggs, and logic flaws."

I hope this covers off your feedback, as we also felt that the section was pretty dire and unreviewable.

@vanderaj vanderaj modified the milestones: 2.1, 3.0 Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants