Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the repository value? #15

Closed
kingthorin opened this issue Feb 7, 2024 · 12 comments
Closed

Default the repository value? #15

kingthorin opened this issue Feb 7, 2024 · 12 comments

Comments

@kingthorin
Copy link

Won't this almost always be the necessary value?

repository: ${{ github.repository }}

Why not simply default it and allow users to override instead of requiring it to be set as a with value?

@kingthorin kingthorin changed the title Default the repository value Default the repository value? Feb 7, 2024
@DonnieBLT
Copy link
Collaborator

Good call! Thanks. @JisanAR03 can you make that change please?

@JisanAR03
Copy link
Contributor

Good call! Thanks. @JisanAR03 can you make that change please?

@DonnieBLT yeah sir sure

@JisanAR03
Copy link
Contributor

@DonnieBLT sir , we can close this issue

@kingthorin
Copy link
Author

kingthorin commented Feb 8, 2024

@JisanAR03
Copy link
Contributor

@JisanAR03 For future reference you can close issues from pull requests on merge using keywords: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

@kingthorin sir , Thanks for the docs sir, I will something about it for sure☺

@JisanAR03
Copy link
Contributor

@DonnieBLT sir , to close an issue automatically, as @kingthorin sir says, I come with a solution.

  • We can do "if (eventType == "pull_request")" in the existing index.js file, and based on the condition, if the user mentions the issue number like "fix_issue_#10," the issue will close automatically when the PR has approval for the merge.

It's just an approach, sir. Any suggestions for me to implement auto-issue close action?

@kingthorin
Copy link
Author

kingthorin commented Feb 9, 2024

Oh I was just pointing it out for the next time you worked on an issue so that you didn't have to ask someone to close things.

I didn't mean for it to be something you had to integrate. (If you can and want to then cool, but that wasn't the point 🙂)

@DonnieBLT
Copy link
Collaborator

Also, if you use GitHub to create the branch from the issue, it will automatically link it to the information section on the right.

@JisanAR03
Copy link
Contributor

@kingthorin , sorry for my misunderstanding, sir😬
@DonnieBLT ok sir sure😊

@kingthorin
Copy link
Author

No worries. Looking back I wasn't very clear.

@kingthorin
Copy link
Author

For my 2 cents this issue has been addressed, I'm happy to close it if you want. Just let me know @JisanAR03

@JisanAR03
Copy link
Contributor

For my 2 cents this issue has been addressed, I'm happy to close it if you want. Just let me know @JisanAR03

@kingthorin yes sir sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants