Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Cross-Site Request Forgery Prevention Cheat Sheet #1388

Closed
wittjoe1 opened this issue Apr 19, 2024 · 1 comment
Closed

Update: Cross-Site Request Forgery Prevention Cheat Sheet #1388

wittjoe1 opened this issue Apr 19, 2024 · 1 comment
Assignees
@wittjoe1
Labels
ACK_OBTAINED Issue acknowledged from core team so work can be done to fix it. UPDATE_CS Issue about the update/refactoring of a existing cheat sheet.

Comments

@wittjoe1
Copy link
Contributor

What is missing or needs to be updated?

I'm wondering about the title of the chapter "Disallowing **non-**simple requests".
In my opinion - and from the context - it should read "Disallowing simple requests", as "simple" requests lead to CSRF, which we actually want to prevent.

How should this be resolved?

Can someone please check this? Thx
@wittjoe1 wittjoe1 added ACK_WAITING Issue waiting acknowledgement from core team before to start the work to fix it. HELP_WANTED Issue for which help is wanted to do the job. UPDATE_CS Issue about the update/refactoring of a existing cheat sheet. labels Apr 19, 2024
@jmanico
Copy link
Member

jmanico commented Apr 19, 2024

This is a good observation. Care to submit a PR for us?

@wittjoe1 wittjoe1 mentioned this issue Apr 22, 2024
Merged
8 tasks
@mackowski mackowski added ACK_OBTAINED Issue acknowledged from core team so work can be done to fix it. and removed ACK_WAITING Issue waiting acknowledgement from core team before to start the work to fix it. HELP_WANTED Issue for which help is wanted to do the job. labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wittjoe1 wittjoe1

Labels
ACK_OBTAINED Issue acknowledged from core team so work can be done to fix it. UPDATE_CS Issue about the update/refactoring of a existing cheat sheet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmanico @mackowski @wittjoe1