Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for old Ruby/Rails versions #813

Closed
brian-kephart opened this issue May 17, 2018 · 3 comments
Closed

Support for old Ruby/Rails versions #813

brian-kephart opened this issue May 17, 2018 · 3 comments

Comments

@brian-kephart
Copy link
Collaborator

brian-kephart commented May 17, 2018

The documentation says Camaleon supports Ruby 1.9 and Rails 4.1, but that's not really the case right now.

  • Some of the dependencies in the gemspec require Ruby 2.0, or even 2.2, so the current version of Camaleon can't be installed with Ruby 1.9.
  • Running Rubocop reveals multiple cases of syntax in the code that is incompatible with Ruby 1.9.
  • Rails 4.1 predates ActiveJob. Running the tests when using Rails 4.1 results in this error:
NoMethodError:
       undefined method `deliver_later' for #<Mail::Message:0x0000000a224e80>
     # ./app/helpers/camaleon_cms/email_helper.rb:29:in `cama_send_email'
     # ./app/helpers/camaleon_cms/email_helper.rb:17:in `send_email'
     # ./spec/helpers/email_helper_spec.rb:7:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:28:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:27:in `block (2 levels) in <top (required)>'

Rails 4.2+ works fine. Ruby 2.2+ works fine.

The versions of Ruby and Rails that aren't currently working with Camaleon have been unmaintained for multiple years now, so I favor dropping them from the documentation for future development. Otherwise, we should manage dependencies so these versions actually work.

@owen2345
Copy link
Owner

Hi @brian-kephart
I agree with you, we can drop old versions and change ruby/rails minimum versions.
Cheers!

@brian-kephart
Copy link
Collaborator Author

Thanks for the fast reply! I’ll submit a PR. What about Ruby 2.2 and Rails 4.2? They are unmaintained as well, but not causing any build problems. Should we keep them or not?

@owen2345
Copy link
Owner

We can keep them, because if we change it we can affect existent projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants