Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fix prevents testing plugins #817

Closed
brian-kephart opened this issue May 22, 2018 · 2 comments
Closed

Test fix prevents testing plugins #817

brian-kephart opened this issue May 22, 2018 · 2 comments

Comments

@brian-kephart
Copy link
Collaborator

This line causes problems when I try to test my plugins. Since I'm running my plugin tests from a different repo, the file path doesn't render correctly and my tests throw an exception.

A comment in the rendered file says it's needed to work around a TinyMCE bug. I tried running the Camaleon test suite with that line commented out and it passed, so maybe the workaround is no longer needed.

If it's still needed, can we just place the necessary content in a conditional block in the view, instead of rendering it from a file?

@owen2345
Copy link
Owner

@brian-kephart you are right, can you please make a pull request with the change?
Regards!

@brian-kephart
Copy link
Collaborator Author

Yes, but which change? Remove that line, or inline the code from the file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants