Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behavior when ccat directory #71

Open
ysv opened this issue Oct 1, 2018 · 5 comments
Open

Wrong behavior when ccat directory #71

ysv opened this issue Oct 1, 2018 · 5 comments

Comments

@ysv
Copy link

ysv commented Oct 1, 2018

When I ccat directory I expect some error message but ccat shows nothing
screen shot 2018-10-01 at 11 29 13 am

Also exit status is 0
screen shot 2018-10-01 at 11 33 54 am

@jackwilsdon
Copy link

jackwilsdon commented Oct 3, 2018

I can't reproduce this with the latest version of ccat on either macOS or Ubuntu 18.04.

$ mkdir -p /tmp/example
$ ccat /tmp/example
/tmp/example is a directory

It looks like the check has been in there for around 2 years too, so it's unlikely you're on that old of a version: 09c185b

Is your ccat an alias of anything?

@ysv
Copy link
Author

ysv commented Oct 9, 2018

@jackwilsdon I've just checked in fresh MacOs and still have this issue
I've installed ccat using brew brew install ccat
here is my version

ccat -v
ccat v1.1.0

Also no aliases

which ccat
/usr/local/bin/ccat

@jackwilsdon
Copy link

Ah, that'll be it! I installed the latest version from master. Looks like the v1.1.0 tag doesn't include the directory check, see this diff between v1.1.0 and the commit that introduced the check.

It looks like there's been quite a few changes since v1.1.0, maybe we need a v2.0.0 tagging and updating on Homebrew? @jingweno

@ysv
Copy link
Author

ysv commented Oct 11, 2018

@jackwilsdon So the problem is outdated version in Homebrew.
I think it worth to be fixed

@ysv
Copy link
Author

ysv commented Jun 28, 2019

@jackwilsdon so was it fixed
May I close this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants