Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to Windows/Linux #18

Open
PaulBGD opened this issue Sep 17, 2015 · 13 comments
Open

Porting to Windows/Linux #18

PaulBGD opened this issue Sep 17, 2015 · 13 comments

Comments

@PaulBGD
Copy link

PaulBGD commented Sep 17, 2015

What would be required to port this to Windows/Linux?

@nanaeasiedu
Copy link

I'm on Windows and it didn't build on it due to nslog package. When I removed the nslog package and it's related code, I built it and it worked.

@PaulBGD
Copy link
Author

PaulBGD commented Sep 17, 2015

Yeah I'm seeing the same thing, let me try removing nslog.

@PaulBGD
Copy link
Author

PaulBGD commented Sep 17, 2015

I did get it working, although it spans multiple monitors unless I add a few icons. This works great nonetheless!

@nanaeasiedu
Copy link

Spans multiple monitors??

@PaulBGD
Copy link
Author

PaulBGD commented Sep 17, 2015

Yeah, half is on one and half is on the other. Adding more icons to the right of the hacker menu icon temporarily fixed this.

@nanaeasiedu
Copy link

Alright!

@owenthereal
Copy link
Owner

I confirmed that nslog is causing issues when compiling on Windows. We'd need to a find an alternative of it. However, the menu doesn't pop up on Windows 10 when clicked, will need to investigate more:

screen shot 2015-09-17 at 8 45 00 pm

@PaulBGD
Copy link
Author

PaulBGD commented Sep 18, 2015

Showed up fine for me, maybe you need to use the official Windows 10?

@onbjerg
Copy link

onbjerg commented Sep 20, 2015

I am currently writing a packaging script for Windows (and Linux) in #25. It builds for me on Windows 10 without issues.

Care to test for me?

@PaulBGD
Copy link
Author

PaulBGD commented Sep 20, 2015

> hacker-menu@1.1.3 build c:\Users\Paul\hacker-menu
> babel src -D -d dist --compact true

src\client\main.js -> dist\client\main.js
src\client\menu.js -> dist\client\menu.js
src\client\spinner.js -> dist\client\spinner.js
src\client\story.js -> dist\client\story.js
src\client\story_box.js -> dist\client\story_box.js
src\client\story_list.js -> dist\client\story_list.js
src\index.js -> dist\index.js
src\logger.js -> dist\logger.js
src\model\read_cache.js -> dist\model\read_cache.js
src\model\story_manager_status.js -> dist\model\story_manager_status.js
src\model\story_type.js -> dist\model\story_type.js
src\server\auto_update_manager.js -> dist\server\auto_update_manager.js
src\server\story_manager.js -> dist\server\story_manager.js
src\server\tray_manager.js -> dist\server\tray_manager.js
'.' is not recognized as an internal or external command,
operable program or batch file.

@PaulBGD
Copy link
Author

PaulBGD commented Sep 20, 2015

If we're porting to Windows, creating an installer with https://github.com/atom/grunt-electron-installer would be great.

@owenthereal
Copy link
Owner

You can now run script/package --all to build for all platforms. But somehow the menu didn't pop up for Windows 10. I created an issue: max-mapper/menubar#67.

@onbjerg
Copy link

onbjerg commented Oct 7, 2015

The menu pops up on Windows 10, but when I click outside the menu in order to close it, it just goes blank. In order to make it work again, I have to right click on a process in my task bar called Electron and click "Close Window".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants