Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for CGraph #538

Open
tachukao opened this issue Jul 24, 2020 · 2 comments
Open

Unit Tests for CGraph #538

tachukao opened this issue Jul 24, 2020 · 2 comments

Comments

@tachukao
Copy link
Member

As discussed in #531, we should add an unit test module for CGraph. Although most of the operations are defined in Algodiff, we should have unit tests for the init, shape, and optimization functions.
Any ideas on how to best test for these @pvdhove @ryanrhymes @mseri @jzstark ?

@ryanrhymes
Copy link
Member

Probably the tests can be divided into several groups.

  • Basic operations like adding, removing, modifying nodes.
  • Shape inference functions.
  • Structural optimisation functions.
  • Anything esle?

open to criticisms :)

@jzstark
Copy link
Collaborator

jzstark commented Jul 25, 2020

Agree. The optimiser and shape interence tests in TensorFlow might be of help, such as optimizer_cse_test.cc, constant_folding_test.cc, shape_inference_test.cc, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
owl development
  
Awaiting triage
Development

No branches or pull requests

5 participants