Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive Ownership transfer events occur on an object named Bar Sink. #60

Closed
Superbstingray opened this issue Aug 13, 2022 · 2 comments
Labels

Comments

@Superbstingray
Copy link

Describe the Bug
There are Excessive Ownership transfer events that occur on an object named Bar Sink. This is likely reducing performance to some extent as it seems to run multiple times per frame increasing its frequency depending on how many players are in the world. This also results in a large output log file size.

Steps To Reproduce
Enter the world with an instance that has players in it and check the output log.

Expected Behavior
Any networked object should not transfer ownership that many times per second/frame.

Screenshots

PugOwnershipTransfer.mp4

OutputLog
View attached video.

Are you in VR or Desktop mode?
Both.

Additional Context

@owlboy
Copy link
Owner

owlboy commented Aug 13, 2022

Thank you, I'll get this sorted out today.

@owlboy owlboy added the bug label Aug 13, 2022
@owlboy owlboy closed this as completed Aug 13, 2022
@owlboy
Copy link
Owner

owlboy commented Aug 13, 2022

This should be fixed now. Thank you for the detailed report! 😃

The bar sink scripts have been totally rewritten to use events, and the faucet handles should be more responsive now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants