Add Equality assertions for json_path
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We separate json path assertions from the body DSL. This commit adds a new method json_path and implements the `Equality` trait. Also bring a new way to format logs for json path that can be later propagated to the other assertions.
theredfish
commented
Mar 1, 2023
theredfish
commented
Mar 1, 2023
theredfish
force-pushed
the
feat/json-path
branch
from
3dfb989
to
b794ddc
Compare
Also fix how the results were handled. We always need to wrap the user input in an array to match how the jsonpath lib manages the query results.
theredfish
changed the title
Equality assertions for json_path
Users can now assert on json path result. For example:
`json_path("$.shop.total", is(json!(4)))`.
Also update the log settings to handle both unit and compound
assertions for all predicates. Json path introduced some
complexity in the log messages that should be better handle later
through a trait.
Fix #25
theredfish
force-pushed
the
feat/json-path
branch
from
c9fc60c
to
fa7480f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.