Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CustomElements extends work #19

Open
F0rsaken opened this issue Oct 1, 2021 · 0 comments
Open

Make CustomElements extends work #19

F0rsaken opened this issue Oct 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@F0rsaken
Copy link
Member

F0rsaken commented Oct 1, 2021

After some research, it turns out to extend native HTML elements, you need to make a class that extends them, example:

export class CoolButton extends HTMLButton {
    ...
}

window.customElements.define('cool-button', CoolButton, { extends: 'button' });

You need to do both: extend a class and add extends in options.

I think we should postpone fixing this to next version

EDIT 17.12.2021:
I think this feature is not required now and I see no use case for it. We should stall this issue for now.

@F0rsaken F0rsaken created this issue from a note in Ovee Core v2.x (To do) Oct 1, 2021
This was referenced Oct 1, 2021
@przyb przyb added enhancement New feature or request v2.2 labels Oct 3, 2021
@F0rsaken F0rsaken removed the v2.2 label Dec 17, 2021
@F0rsaken F0rsaken removed this from To do in Ovee Core v2.x Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants