Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing HTML instead of a link for external actions #1718

Closed
gabek opened this issue Feb 1, 2022 · 2 comments · Fixed by #2693
Closed

Allow providing HTML instead of a link for external actions #1718

gabek opened this issue Feb 1, 2022 · 2 comments · Fixed by #2693
Assignees
Labels
backlog Ideas that might be cool and can be looked into later. enhancement New feature or request Web frontend Issues dealing with the web site

Comments

@gabek
Copy link
Member

gabek commented Feb 1, 2022

Right now we allow people to point an external action button to any URL that we can open in a modal. I believe this feature hasn't been fully adopted because people don't have custom HTML hosted anywhere, it's an additional step.

Instead we could allow people to paste in whatever raw HTML they want, and we can render it for them without an additional server being required.

While this wouldn't be totally useful for somebody building some new feature from scratch, if people just wanted to embed a 3rd party "embed code" copy/paste from another site it would work well here.

Examples:

@gabek gabek added enhancement New feature or request backlog Ideas that might be cool and can be looked into later. Web frontend Issues dealing with the web site labels Feb 1, 2022
@xarantolus
Copy link
Contributor

xarantolus commented Feb 6, 2023

Hey, I'd be interested in working on this. I'll try adding an HTML field to the external action types and then use that if it's non-empty (otherwise use the URL) to display in the modal if that's OK :)

@gabek
Copy link
Member Author

gabek commented Feb 6, 2023

Yeah, totally go for it!

Maybe the UI could have a switch where you choose either a link or HTML. I only mention that because if you choose HTML we'd have to hide the "Open externally" checkbox, because that option wouldn't make sense in that context. But also open for other ideas that makes it clear what's going on.

Thanks for wanting to look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Ideas that might be cool and can be looked into later. enhancement New feature or request Web frontend Issues dealing with the web site
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants