Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading custom emoji through the admin #2378

Closed
gabek opened this issue Nov 24, 2022 · 2 comments · Fixed by #2411
Closed

Allow uploading custom emoji through the admin #2378

gabek opened this issue Nov 24, 2022 · 2 comments · Fixed by #2411
Assignees
Labels
admin Issues related to the Admin portion API A new API is required backlog Ideas that might be cool and can be looked into later.

Comments

@gabek
Copy link
Member

gabek commented Nov 24, 2022

Share your bug report, feature request, or comment.

It would be useful for people to have a way to manage custom emoji images through the admin instead of through the filesystem of the machine Owncast is running on.

  • Upload new images
  • Delete unwanted ones

Note: Starting withwebv2 emoji images are pulled from data/emoji and no longer the old webroot.

@gabek gabek added backlog Ideas that might be cool and can be looked into later. API A new API is required admin Issues related to the Admin portion labels Nov 24, 2022
@xarantolus
Copy link
Contributor

xarantolus commented Dec 5, 2022

Hey, I'd be interested in working on this. I think it would make sense to put this setting under "Chat & Users" as a new category and then create a menu similar to the external actions table.
One question on this: The emoji listing should show both emojis from data/emoji and static/img/emoji, right? When a user deletes one of the static ones, should we delete it from the file system or somehow mark it as unused in the database?
Also, should it be enforced that the image is square (and should we limit the size/automatically downscale to prevent a single emoji from being too large)?

@gabek
Copy link
Member Author

gabek commented Dec 5, 2022

Awesome, thank you! And these are all good questions!

The emoji listing should show both emojis from data/emoji and static/img/emoji, right?

So as it stands, if you create your own custom emoji directory in data/emoji then it overrides the emoji that are bundled into the application. Because the bundled emoji are literally built into the application there's no way to delete them. So unless we changed how that whole process works it's "100% custom" or "100% built-in". We could merge custom and built-in, but it might be weird that you'd be able to delete some of them (the custom ones) but no the built-in ones.

We could also do something completely different like on first launch copy the built-in emoji into data/emoji and then allow people to delete them and add their own.

Also, should it be enforced that the image is square (and should we limit the size/automatically downscale to prevent a single emoji from being too large)?

I don't think we should be concerned too much with that. Let people do what they want to do. Besides, if they just copy a directory of custom emoji to data/emoji then there wouldn't be any way for us to inspect them anyway.

@gabek gabek linked a pull request Dec 6, 2022 that will close this issue
@gabek gabek added this to the v0.1.0 - Web frontend v2 milestone Dec 12, 2022
@gabek gabek closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Issues related to the Admin portion API A new API is required backlog Ideas that might be cool and can be looked into later.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants