Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin logo upload UI sending empty payloads #2524

Closed
gabek opened this issue Dec 28, 2022 · 2 comments · Fixed by #2531
Closed

Admin logo upload UI sending empty payloads #2524

gabek opened this issue Dec 28, 2022 · 2 comments · Fixed by #2531
Assignees
@andrew-secret
Labels
admin Issues related to the Admin portion bug Something isn't working Web frontend Issues dealing with the web site
Milestone
v0.1.0 - Web fron...

Comments

@gabek
Copy link
Member

gabek commented Dec 28, 2022

Share your bug report, feature request, or comment.

I found when testing #2522 that the web frontend is sometimes sending empty payloads to the backend when trying to upload an image. It feels random. Sometimes it works, sometimes it doesn't. It may be due to types of file, or name, or permissions or something but it doesn't seem like it's related to the backend.

image
@gabek gabek added bug Something isn't working Web frontend Issues dealing with the web site admin Issues related to the Admin portion labels Dec 28, 2022
@gabek gabek added this to the v0.1.0 - Web frontend v2 milestone Dec 28, 2022
@gabek gabek mentioned this issue Dec 28, 2022
Merged
@andrew-secret
Copy link
Contributor

I can take a look at this 😇

@gabek
Copy link
Member Author

gabek commented Dec 28, 2022

Nice!

@andrew-secret andrew-secret mentioned this issue Dec 29, 2022
Merged
@gabek gabek linked a pull request Dec 29, 2022 that will close this issue
wrap promise response in set timeout to keep local state in sync #2531
Merged
@gabek gabek closed this as completed Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-secret andrew-secret

Labels
admin Issues related to the Admin portion bug Something isn't working Web frontend Issues dealing with the web site
Projects
None yet
Milestone
v0.1.0 - Web frontend v2
Development

Successfully merging a pull request may close this issue.

wrap promise response in set timeout to keep local state in sync andrew-secret/owncast
2 participants
@gabek @andrew-secret