Skip to content
This repository has been archived by the owner on Mar 8, 2019. It is now read-only.

[security] Ensure to retrieve the correct PGP public keys by importing by there fingerprint. #45

Open
ypid opened this issue Apr 19, 2016 · 5 comments

Comments

@ypid
Copy link

ypid commented Apr 19, 2016

See jchaney/owncloud#12

Vulnerable lines: https://github.com/owncloud/vm/blob/cf6aa232b4e6731bddf00dfd804070cd461eeeb2/vagrant/oc9ce/build-ubuntu-vm.sh#L136

Downloading the PGP key via HTTP and then downloading the packages from the same origin does not make any sense!

@ypid
Copy link
Author

ypid commented Jan 16, 2017

BTW. The fix which has been merged into https://github.com/nextcloud/vm could also be used here.
The build script still downloads both the packages and OpenPGP key via HTTP without even checking the fingerprint.
Ref: nextcloud/vm#19

@enoch85
Copy link

enoch85 commented Jan 16, 2017

@ypid Have you seen this? nextcloud/vm#52

Does this has to do with anything in this issue?

Please create a PR, this is not my expertise area.

@enoch85
Copy link

enoch85 commented Jan 16, 2017

Oh, sorry, thought we were on the Nextcloud VM repo now. Just realized that this is the ownCloud repo. Anyway, please make a PR. :)

Thanks!

@ypid
Copy link
Author

ypid commented Jan 16, 2017

I don’t use either of your VMs. I just wanted to draw your attention back at this issue which makes your build process vulnerable. Please feel encouraged to get familiar with this area and I will be happy to review your PR and give you feedback.

@enoch85
Copy link

enoch85 commented Jan 16, 2017

cc @kawohl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants