Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap acceptance tests #12

Closed
patrickjahns opened this issue Aug 20, 2018 · 3 comments · Fixed by #17 or #22
Closed

Bootstrap acceptance tests #12

patrickjahns opened this issue Aug 20, 2018 · 3 comments · Fixed by #17 or #22
Assignees
Labels

Comments

@patrickjahns
Copy link
Contributor

Basic acceptance tests for ensuring the brute-force works as designed

These tests include:

Ensuring other users with the same IP can login

  • ensure user1 with ip1 is blocked after x failed attempts
  • ensure user2 with ip1 can still login

Ensuring that same user with different IP can login

  • ensure user1 with ip1 is blocked after x failed attempts
  • ensure user1 with ip2 is allowed to login

Note - some things we might used during acceptance testing:
X-Forwarded-For Header would allow us to set an arbitrary IP in the scenario above

@phil-davis
Copy link
Contributor

We might be able to use the Ip.php core acceptance tests trait that helps firewall to initiate requests from different IP addresses on the local machine. It is likely that there could be 3 addresses always available - drone 172.17.., localhost, and a "real" IP address of the machine. Server on 1 of them and requests can come in from the others.

@individual-it
Copy link
Member

this is not fixed yet completely, reopening

@individual-it
Copy link
Member

tried with Ip.php but as we run the tests on a remote system in drone we only have one IP address that we can use. Will think about use of X-Forwarded-For

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants