New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust showing timezone #961
Conversation
okkez
commented
Oct 25, 2018
- Disable timezone button when the event is all day
- Hide timezone select box when the event is all day event and read-only
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
=======================================
Coverage 57.17% 57.17%
=======================================
Files 66 66
Lines 3402 3402
=======================================
Hits 1945 1945
Misses 1457 1457 Continue to review full report at Codecov.
|
Timezone button seems disable due to it is coloured in grey, but it stills been possible to click on the hours @Julian1998 @okkez jfyi |
IMHO this is not wrong nor is it bad. |
@alfredbuehler I totally agree! Let's see what the others say @DeepDiver1975 @PVince81 |
@davitol No bug! And not part of this issue anyway ;) |
@alfredbuehler @Julian1998 Thanks for your answer. So probably I misunderstood the purpose of the PR. |
@davitol Thx! Yeah I know that issue but it's not that important right now! Something for the community or future |