Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust showing timezone #961

Merged
merged 2 commits into from Nov 4, 2018
Merged

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Oct 25, 2018

  • Disable timezone button when the event is all day
  • Hide timezone select box when the event is all day event and read-only

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.322% when pulling 68b2106 on okkez:adjust-showing-timezone into c2bfb22 on owncloud:master.

@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #961 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #961   +/-   ##
=======================================
  Coverage   57.17%   57.17%           
=======================================
  Files          66       66           
  Lines        3402     3402           
=======================================
  Hits         1945     1945           
  Misses       1457     1457

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2bfb22...68b2106. Read the comment docs.

@Julian1998 Julian1998 merged commit 3faec10 into owncloud:master Nov 4, 2018
@okkez okkez deleted the adjust-showing-timezone branch November 5, 2018 00:33
@PVince81 PVince81 mentioned this pull request Dec 6, 2018
24 tasks
@PVince81 PVince81 added this to the QA milestone Dec 6, 2018
@davitol
Copy link
Contributor

davitol commented Dec 10, 2018

blocked

Timezone button seems disable due to it is coloured in grey, but it stills been possible to click on the hours

@Julian1998 @okkez jfyi

@alfredbuehler
Copy link

IMHO this is not wrong nor is it bad.

@Julian1998
Copy link
Contributor

@alfredbuehler I totally agree! Let's see what the others say @DeepDiver1975 @PVince81

@Julian1998
Copy link
Contributor

@davitol No bug! And not part of this issue anyway ;)

@davitol
Copy link
Contributor

davitol commented Dec 11, 2018

@alfredbuehler @Julian1998 Thanks for your answer. So probably I misunderstood the purpose of the PR.

@davitol
Copy link
Contributor

davitol commented Dec 11, 2018

I think i got the purpose if this PR now. It works as expected. Just an small detail. The timezone icon inside the box gets a bit shifted. To be fixed if possible in other PR.

screen shot 2018-12-11 at 08 59 16
screen shot 2018-12-11 at 08 58 59

@Julian1998
Copy link
Contributor

@davitol Thx! Yeah I know that issue but it's not that important right now! Something for the community or future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants