Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with catalan translation #814

Closed
ghost opened this issue Sep 19, 2017 · 10 comments
Closed

Problem with catalan translation #814

ghost opened this issue Sep 19, 2017 · 10 comments
Labels

Comments

@ghost
Copy link

ghost commented Sep 19, 2017

OwnCloud 10.0.2 (stable)
Calendar version 1.5.4

The file /apps/calendar/js/public/vendor.min.js has the catalan translation in what I suppose it's the old format. The month names for example are displayed as "Undefined" instead of the proper way.

I would send a patch against the file in the git repo but it's simply not there. I can't find any vendor.min.js file in the calendar git or even in the core project. Anyway, attached is the corrected vendor.min.js file and at least it works for me (I just changed the catalan translation to match the new format).

vendor.min.js.zip

@duub
Copy link

duub commented Sep 22, 2017

having same issue with oc 10.0.3 and calendar 1.5.4

@DeepDiver1975
Copy link
Member

@serginuez can you please point me to the change you did? Its not that easy to find your changes - THX

@ghost
Copy link
Author

ghost commented Dec 28, 2017

the catalan part is the attached (as it's minified and I cannot find the regular file it's really a mess to manage it). I had to redo all the catalan section, as the variables and structures used looked like they were written for an older i18n format.

catalan.txt

@Julian1998
Copy link
Contributor

Julian1998 commented Jan 27, 2018

@serginuez Is this fixed in oc 10.0.5? I switched to catalan and the month names are working fine?
The file you searched for is https://github.com/owncloud/core/blob/v9.1.6/core/vendor/moment/min/moment-with-locales.js

@ghost
Copy link
Author

ghost commented Jan 28, 2018

just updated to 10.0.5 and it still says undefined. Made a clean install and got the same result. Are you sure that the moment-with-locales.js is the file that creates apps/calendar/js/public/vendor.min.js? There are differences between them, strings that appear on the latter and not on the former.
If I set it to another language (italian for example) it works fine.

@Julian1998
Copy link
Contributor

@serginuez So I switched to catala and it's working fine... Sorry that I have to ask that but did you run the Makefile?

@Julian1998
Copy link
Contributor

@serginuez Please test that PR so I can see if Catalan is fixed now :)

#907

@ghost
Copy link
Author

ghost commented Mar 21, 2018

Sorry, but I've tried to build the calendar app and I keep getting npm build errors, which I'm quite sure are because I have somenthing missing in my system or something not well configured (I have never worked with nodejs).

@DeepDiver1975
Copy link
Member

you can test our rc - calendar-1.5.8-rc1.tar.gz

@DeepDiver1975
Copy link
Member

closing since the user disappeared from github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants