Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use wellknown if not needed #44

Merged
merged 1 commit into from Feb 19, 2016
Merged

Don't use wellknown if not needed #44

merged 1 commit into from Feb 19, 2016

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 added this to the 1.0-current milestone Feb 18, 2016
@Henni
Copy link
Contributor

Henni commented Feb 18, 2016

Looks good to me. Still works and there is no 404 anymore.

@DeepDiver1975
Copy link
Member Author

rebased

@nickvergessen
Copy link
Contributor

For me it still queries the well-known, because the actual lib patch is missing

@nickvergessen
Copy link
Contributor

But then again, the thing only makes a get request, which returns

This is the WebDAV interface. It can only be accessed by WebDAV clients such as the ownCloud desktop sync client.

So maybe we should just kill that get call completly...

@DeepDiver1975
Copy link
Member Author

But then again, the thing only makes a get request, which returns

grrr - where did it go?

@DeepDiver1975 DeepDiver1975 self-assigned this Feb 19, 2016
@DeepDiver1975
Copy link
Member Author

For me it still queries the well-known, because the actual lib patch is missing

fixed - please test again - thx

@DeepDiver1975
Copy link
Member Author

@nickvergessen THX

@DeepDiver1975
Copy link
Member Author

rebased again

@irgendwie
Copy link
Contributor

LGTM 👍

DeepDiver1975 added a commit that referenced this pull request Feb 19, 2016
@DeepDiver1975
Merge pull request #44 from owncloud/fix-welknown-issue-41
c206420 
Don't use wellknown if not needed
@DeepDiver1975 DeepDiver1975 merged commit c206420 into master Feb 19, 2016
@DeepDiver1975 DeepDiver1975 deleted the fix-welknown-issue-41 branch February 24, 2016 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DeepDiver1975 DeepDiver1975

Labels
3 - to review
Projects
None yet
Milestone
1.0-current
Development

Successfully merging this pull request may close these issues.

Do not use .well-known/carddav url
4 participants
@DeepDiver1975 @Henni @nickvergessen @irgendwie