Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2FA login selection should be adapted to the new design #237

Open
prsnbrg opened this issue Jul 23, 2021 · 8 comments · Fixed by #232
Open

2FA login selection should be adapted to the new design #237

prsnbrg opened this issue Jul 23, 2021 · 8 comments · Fixed by #232

Comments

@prsnbrg
Copy link
Contributor

prsnbrg commented Jul 23, 2021

With oC 10.8 and latest twofactor_totp app the login selection for 2FA looks like this:
image

I think the 2FA login selection should be adapted to the new design.

Also, it would help if the selections are displayed as buttons so each option can be easily identified as such. owncloud/core#38608
@JammingBen
Copy link
Contributor

@hurradieweltgehtunter fyi

@phil-davis
Copy link
Contributor

Also see issues:
#231
owncloud/twofactor_backup_codes#30

@xoxys
Copy link

xoxys commented Jul 27, 2021

grafik

@AlexAndBear
Copy link

@hurradieweltgehtunter has those changes be merged, can we close the issue ?

@hurradieweltgehtunter
Copy link
Contributor

AFAIK not, needs update in tests. Could you have a look? -> #232

@AlexAndBear
Copy link

Sure 🙌

@AlexAndBear AlexAndBear transferred this issue from owncloud/core Sep 29, 2021
@AlexAndBear AlexAndBear mentioned this issue Sep 29, 2021
Merged
@prsnbrg
Copy link
Contributor Author

prsnbrg commented Nov 14, 2021

The overview of 2fa options is implemented in core.
Please reopen this issue.

There is the same graphical error as in this app. The line of the upper box is not continuous.

@JammingBen JammingBen reopened this Dec 10, 2021
@JammingBen
Copy link
Contributor

Reopening because we still have issues. It seems to be related to the selected language (=word length). When setting to German:

image

@JammingBen JammingBen mentioned this issue Dec 10, 2021
Merged
@jnweiger jnweiger mentioned this issue Jan 14, 2022
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[full-ci] Adapt to new login design owncloud/twofactor_totp
6 participants
@phil-davis @xoxys @hurradieweltgehtunter @AlexAndBear @prsnbrg @JammingBen