Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Heavily reworked the antivirus section #2947

Merged
merged 3 commits into from Jul 14, 2017

Conversation

settermjd
Copy link
Contributor

This PR:

  • Heavily reworks the the antivirus section. There were sections that needed to be updated to the latest version, plus the way in which it was written wasn't as clear as it could be. Given that, I decided to make a series of updates so that it was both up to date and much clearer.

@mention-bot
Copy link

@settermjd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vgezer to be a potential reviewer.


To enable the Antivirus App for Files, go to your ownCloud Apps page to enable
it.
To updates your malware database and get the latest malware signatures, you need to run ``freshclam`` frequently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/updates/update

@settermjd settermjd force-pushed the refactor-antivirus-configuration branch from 8fba2fa to 5151af5 Compare March 22, 2017 08:45
To enable it, navigate to ``Settings -> Admin -> Apps``.
It should already be enabled.
But, if it’s not, click "**Show disabled apps**", find it in the list, and click
"**Enable**".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add occ command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do.

``Action for infected files found while scanning`` gives you the choice of
logging any alerts without deleting the files, or immediately deleting
infected files.
``Action for infected files found while scanning`` gives you the choice of logging any alerts without deleting the files or immediately deleting infected files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, @VicDeo can the configuration also be done via occ? would be great for docker setups / automated deployments. Can you give examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble with a local install and don't see the anti-virus app when running ./occ app:list. Not sure if I'm missing something. But given its not there, I can't do due diligence on this section of the file.

view and change the existing rules. You can also add new ones.
ownCloud provides the ability to customize how it reacts to the response given by an anti-virus scan.
To do so, under `Admin -> Antivirus Configuration -> Advanced`, which you can see in the screenshot below, you can view and change the existing rules.
You can also add new ones.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If admins use ClamAV do they have to customize the rules? Are there default rules? what do they match? I assume ClamAV?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to look into that. Can anyone else advise?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avrules

wow there is a ton of default rules ...

Copy link
Contributor

@VicDeo VicDeo Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butonic

If admins use ClamAV do they have to customize the rules?

They don't. Default ruleset for clamAv is populated automatically.
Scanner exit status rules are used to handle errors when ClamAv is run in CLI mode while
Scanner output rules are used in daemon/socket mode.

Exit status is basically an exit code returned by any binary (not necessary ClamAv)
Daemon output is parsed by regexp.

IIRC the rules are always checked in the following order: infected/error/clean. In case there are no matching rules, the status would be Unknown and a warning would be logged.

@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2017

any update ? how to move forward ? @settermjd @VicDeo

needs rebase due to conflicts

@settermjd
Copy link
Contributor Author

@PVince81 will get on it. It got lost under the proverbial pile, unfortunately.

There were sections that needed to be updated to the latest version,
plus the way in which it was written wasn't as clear as it could be.
@settermjd settermjd force-pushed the refactor-antivirus-configuration branch from d8443d1 to 8a17c5e Compare July 14, 2017 08:48
@settermjd
Copy link
Contributor Author

@PVince81, now updated. Ready for further review.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@settermjd
Copy link
Contributor Author

Thanks, @phil-davis.

@settermjd settermjd merged commit 25648fc into master Jul 14, 2017
@settermjd settermjd deleted the refactor-antivirus-configuration branch July 14, 2017 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants