Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable file picker for ownCloud Infinite Scale and therewith Spaces #194

Open
12 tasks done
hodyroff opened this issue Mar 17, 2023 · 4 comments
Open
12 tasks done

Comments

@hodyroff
Copy link
Contributor

hodyroff commented Mar 17, 2023

Description

User Stories

  • As a user who stores her files on ownCloud, I want to choose ownCloud-files from within other applications so that I don't need to leave my current context/app/tab/window.

  • As a user, inside my single-sign on OIDC environment, I like to access a server with ownCloud Infinite Scale, rather then ownCloud 10 using the filepicker.

  • As an ISV I like to include the file picker in my application to access both ownCloud 10 and ownCloud Infinite Scale.
    First step is to enable the same functions as with folders of a user today and the ability to browse personal, shared and all spaces I have see listed.

Value

Acceptance Criteria

  • (If the backend is oc10) Initial view is "All files" (please rename "Home" to "All Files")
  • (If the backend is ocis) We need a new Initial view "root":
    • Headline: "Files"
    • Listing (Order is 1st: "Personal", 2nd "Shares", then Spaces in alphabetical order)
      • Personal
      • Shares
      • Space 1
      • Space 2
      • Space n
  • Breadcrumb: If the current location is not "Files", then show a left caret icon (<); click on < navigates to the parent folder/view
  • Breadcrumb: If the current location is not "Files", show the name of the subfolder on top
  • Resource listing if the location is not "Files": Folders on top (alphanumeric), then files.
  • Rename Select Resource button to Coose

Technical Notes:

  • We have a new major version 3 of the owncloud-sdk (for WebDAV v2)
  • Graph Client is needed for listing Spaces https://github.com/owncloud/libre-graph-api-typescript-axios/ - this is typescript. filepicker is JS only at the moment.
  • ownCloud Web has a package web-client, which is also published to npmjs.com at https://www.npmjs.com/package/@ownclouders/web-client - the web-client contains types for files and spaces and wraps the owncloud-sdk and graph client for easy API access. Can be used for oC10 and oCIS, so it's recommended to use that. But again, this is typescript.

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues

Scribbles

image

@tbsbdr
Copy link
Contributor

tbsbdr commented Mar 17, 2023

update: added Acceptance Criteria, scribble etc. in initial post

@kulmann
Copy link
Member

kulmann commented Apr 24, 2023

feature-wise done by @LukasHirt 👏 still needs test coverage for this issue to be closed. Also to be done by @LukasHirt

@hodyroff
Copy link
Contributor Author

hodyroff commented Jul 3, 2023

Done with release 0.12

@hodyroff hodyroff closed this as completed Jul 3, 2023
@kulmann
Copy link
Member

kulmann commented Jul 3, 2023

Done with release 0.12

Please keep it open until basic test coverage is done. Those are in progress here #221

@kulmann kulmann reopened this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants