Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification on playback error #109

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Add notification on playback error #109

merged 2 commits into from
Feb 11, 2020

Conversation

felixheidecke
Copy link
Contributor

Add notification if video playback fails.

Bildschirmfoto 2019-08-28 um 10 57 37

Fixes #35

@felixheidecke felixheidecke added 3 - To review bug Something isn't working labels Aug 28, 2019
@felixheidecke felixheidecke self-assigned this Aug 28, 2019
@davitol
Copy link

davitol commented Aug 28, 2019

👎 @felixheidecke I cannot get the new notification:

Tests steps from #35 (comment) and Chrome for Mac Version 76.0.3809.100

Console error was spotted

{"reqId":"Hg7vNxNHyim8Bwh8FJHr","level":2,"time":"2019-08-28T10:05:29+00:00","remoteAddr":"172.21.0.1","user":"admin","app":"no app in context","method":"GET","url":"\/remote.php\/webdav\/big.mp4","message":"File with name big.mp4 could not be located"}

@felixheidecke
Copy link
Contributor Author

felixheidecke commented Aug 28, 2019

@davitol are you sure you compiled? Becauuuuuse … the console error is from … before :-P

Works with FF and Chrome
2019-08-28 16-40-06 2019-08-28 16_43_48

@davitol
Copy link

davitol commented Aug 29, 2019

@felixheidecke Retested and keeps not working for me.

Screen Shot 2019-08-29 at 09 28 19

And I get the log:

{"reqId":"Lm5BlUXvGKJyzugb5zHG","level":2,"time":"2019-08-29T07:27:54+00:00","remoteAddr":"172.18.0.1","user":"admin","app":"no app in context","method":"GET","url":"\/remote.php\/webdav\/big2.mp4","message":"File with name big2.mp4 could not be located"}

Tested in Chrome for Mac Version 76.0.3809.100 and oC 10.3 alpha

@felixheidecke
Copy link
Contributor Author

@davitol looks like I forgot to add this notification for images as well 😅

@felixheidecke
Copy link
Contributor Author

@davitol can you have another look? I think that'll fix it.

@felixheidecke
Copy link
Contributor Author

@davitol ping

@mmattel
Copy link
Contributor

mmattel commented Feb 11, 2020

Ping... any progress ?

@davitol
Copy link

davitol commented Feb 11, 2020

Tested and LGTM

{"reqId":"FFzZAGyQ8WFiXoA1fKib","level":2,"time":"2020-02-11T11:57:58+00:00","remoteAddr":"172.18.0.1","user":"admin","app":"no app in context","method":"GET","url":"\/remote.php\/webdav\/big.mp4","message":"File with name big.mp4 could not be located"}

@davitol
Copy link

davitol commented Feb 11, 2020

BTW Warning Fail to load video data is not translated

@mmattel mmattel merged commit 55d713e into master Feb 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the error-message branch February 11, 2020 12:40
@HanaGemela HanaGemela mentioned this pull request Feb 17, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - To review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper error in case of failed playback
3 participants