-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config.json to support mimetype video/quicktime #194
Conversation
@DeepDiver1975 mind to review |
@mmattel did you test this? Does it work? It doesn't for me - using Chromium 79 and Chrome 80 Half baked solutions are 💩 |
There is no "one fits all" solution for QT, as the implementation is dependent on browser support. You have correctly identified this in your comment. You can easily double check this with https://browserspy.dk/quicktime.php to see if your browser supports it or not. This PR is good for those browsers who have implemented this support. We lose nothing by adding it, for this reason proposing to approve. |
@DeepDiver1975 @felixheidecke ping, would be great if it could make it into the new release... |
👎 from my pov - this is a shitty user experiance |
You know, and I have written, that QT is dependent on if its support is implemented in the browser. |
This is just a note: A possible solution could be to identify via JS/vue if the browser is capable of playing a particular video format.
Where As an idea in |
ccdfc09
to
f2583c4
Compare
Added code to check if a video mimetype is playable by the browser. This leads to following (wanted) behavior:
Tests made with sample videos from https://file-examples.com/index.php/ For an additional test, I removed mp4 from the mime list. @DeepDiver1975 pls recheck |
Fixes #169 Add Support for playing Apple Quicktime (*.mov)