Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show breadcrumb even if we can't access the album #223

Closed
oparoz opened this issue Jul 21, 2015 · 5 comments
Closed

Show breadcrumb even if we can't access the album #223

oparoz opened this issue Jul 21, 2015 · 5 comments

Comments

@oparoz
Copy link
Contributor

oparoz commented Jul 21, 2015

It would be nice to be able to still show a breadcrumb when the user reaches a folder he's not authorised to see or which is located on a storage location with previews disabled.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@deMattin
Copy link

If you switch from files app, the broadcrump is there - also if folder contains no pictures.
If you navigate in galleryplus, you are only able to see and navigate in folder, that contain pictures with possible and showable previews. That's like it is and should be, I think
It's not a good idea for gallery+ navigation to show and even give the possibility to navigate in folder with no showable previews, just to show a message "No rights!" or "Here are pictures, but you are not able to see them - ask your admin or yourself for the reason"

It would be like to show hidden files in a file explorer. Sometimes this is nice, but for "normal users" and "normal use" they should be really hidden.
If there are pictures and they are hidden by a policy, there's a reason for that. So there's no reason to give the information, that there is a folder, that hides something.

Why do you want to show such folders? What is the advantage to show them?
Or do you think of something different?

@oparoz
Copy link
Contributor Author

oparoz commented Jul 21, 2015

Here are the use cases:

  • Folder contains .nomedia
  • Folder is an external share with previews disabled

So you navigate using the Files app and then switch to Gallery and get the message that no pictures could be found in the Gallery and no breadcrumb. That's what I want to fix.

Gallery will only navigate through folders which contain pictures, if you start from the top.

@deMattin
Copy link

Ah ok.
Tested with .nomedia file and switching from files app.
Gallery+ should behave in this case like as switching to a folder with no pictures (showing breadcrump and message text).
Didn't know, that this doesn't already work like that.

@oparoz
Copy link
Contributor Author

oparoz commented Jul 21, 2015

Yeah, I realised that last night while fixing another issue. It's because an error code is returned and it triggers a different code path... 😢

@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#52

@oparoz oparoz closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants