Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the user rotate pictures which support EXIF [$5] #236

Closed
oparoz opened this issue Jul 26, 2015 · 5 comments
Closed

Let the user rotate pictures which support EXIF [$5] #236

oparoz opened this issue Jul 26, 2015 · 5 comments

Comments

@oparoz
Copy link
Contributor

oparoz commented Jul 26, 2015

Pictures which support EXIF can store rotation information, so we could show rotate buttons and store the new value in the file. The thumbnails would need to be cleared and re-rendered.

There is a $5 open bounty on this issue. Add to the bounty at Bountysource.

@oparoz oparoz added this to the backlog milestone Jul 26, 2015
@oparoz oparoz changed the title Rotate pictures which support EXIF Let the use rotate pictures which support EXIF Jul 26, 2015
@oparoz oparoz changed the title Let the use rotate pictures which support EXIF Let the user rotate pictures which support EXIF Jul 26, 2015
@oparoz oparoz changed the title Let the user rotate pictures which support EXIF Let the user rotate pictures which support EXIF [$5] Jul 27, 2015
@oparoz oparoz added the bounty label Jul 27, 2015
@oparoz oparoz mentioned this issue Jul 29, 2015
12 tasks
@ghost
Copy link

ghost commented Aug 17, 2015

This problem seems to be the same as the old gallery app, i think that was fixed. The problem is the thumbnails is stored as .png and not .jpeg. exif info is not contained in .png format.

I think its possible to look at the fixes made to the old gallery app for a indication of how to solve this problem.

owncloud-archive/apps#1568

@oparoz
Copy link
Contributor Author

oparoz commented Aug 17, 2015

Thumbnails and slideshow previews are based off a "max preview" which is created the first time a file is accessed. If the Exif data is correct at that time, then Gallery will show the images with the proper orientation.

So there is no problem anymore, but users want to be able to modify the orientation of pictures they see, in case it's not correct in the JPG itself and that's possible by working directly on the original and re-rendering new thumbnails.

@metzenseifner
Copy link

metzenseifner commented Jul 22, 2016

@oparoz

"max preview" which is created the first time a file is accessed. If the Exif data is correct at that time, then Gallery will show the images with the proper orientation.

I just found your comment while searching for how to the reset gallery for some users. The users who viewed pictures before I uncommented the PHP extension exif.so in /etc/php/php.ini see incorrectly oriented pictures (ignored Orientation tag in metadata). While new users (post-change) have the correct orientation, the wrong orientation problem persists for older users who viewed the images prior to the change. Any way to reset this for users?

@oparoz
Copy link
Contributor Author

oparoz commented Jul 24, 2016

There is no elegant way to reset the previews for a user, because there has been no change to the data itself. Potential solutions:

  • re-upload the images
  • delete all the thumbnails for those users
  • only delete specific thumbnails for those users

@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants